-
Notifications
You must be signed in to change notification settings - Fork 201
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Document how to wrap a field React component into Flow component #3600
Merged
+81
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Language unchecked
English language and AsciiDoc formatting checks haven't been done
label
Aug 14, 2024
vursen
reviewed
Aug 14, 2024
caalador
requested changes
Aug 21, 2024
Co-authored-by: caalador <[email protected]>
Co-authored-by: caalador <[email protected]>
Co-authored-by: caalador <[email protected]>
Co-authored-by: caalador <[email protected]>
Co-authored-by: caalador <[email protected]>
Co-authored-by: caalador <[email protected]>
Co-authored-by: caalador <[email protected]>
caalador
reviewed
Aug 22, 2024
Co-authored-by: caalador <[email protected]>
Co-authored-by: caalador <[email protected]>
Co-authored-by: caalador <[email protected]>
caalador
approved these changes
Aug 22, 2024
mshabarov
reviewed
Aug 22, 2024
@@ -208,3 +208,84 @@ class ReactRouterLayoutElement extends ReactAdapterElement { | |||
|
|||
customElements.define('react-router-layout', ReactRouterLayoutElement); | |||
---- | |||
|
|||
[[wrap-react-component]] | |||
== Wrapping a React Component Into a Flow Component |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be like "Wrapping a React Input Component Into a Flow Field Component".
Sorry for commenting on a closed PR, but just noticed one small remark. Could you change it in another PR ?
mshabarov
pushed a commit
that referenced
this pull request
Aug 22, 2024
…low component #3600 (#3609) * Update PR check configs from master * changing title * Delete .github/workflows/alex.yml --------- Co-authored-by: Jouni Koivuviita <[email protected]>
Language was checked in #3631 . |
russelljtdyer
added
Language checked
English language and AsciiDoc formatting checks done
and removed
Language unchecked
English language and AsciiDoc formatting checks haven't been done
labels
Aug 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Document of an example in React integration docs how to wrap a React component as a Field Flow component with AbstractSinglePropertyField
Fixes #3421